Skip to content

Commit

Permalink
tmf: Fix missing final sonarlint in TimeGraphEntry
Browse files Browse the repository at this point in the history
Fix the SonarLint issue [1] below in TimeGraphEntry. Doing so happens to
fix a few more reported issues being consequences of [1].

Bump the necessary versioning, based on the Eclipse API build.

[1] Make this "public static WITHIN_COMPARATOR" field final.

Change-Id: I88528fc8a5bcfc00f82b708d07f87c500dfbaa1d
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/201541
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
  • Loading branch information
marco-miller committed Apr 28, 2023
1 parent c5327f0 commit 1086ae9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tmf/org.eclipse.tracecompass.tmf.ui/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-Vendor: %Bundle-Vendor
Bundle-Version: 8.1.1.qualifier
Bundle-Version: 9.0.0.qualifier
Bundle-Localization: plugin
Bundle-SymbolicName: org.eclipse.tracecompass.tmf.ui;singleton:=true
Bundle-Activator: org.eclipse.tracecompass.internal.tmf.ui.Activator
Expand Down
2 changes: 1 addition & 1 deletion tmf/org.eclipse.tracecompass.tmf.ui/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</parent>

<artifactId>org.eclipse.tracecompass.tmf.ui</artifactId>
<version>8.1.1-SNAPSHOT</version>
<version>9.0.0-SNAPSHOT</version>

<packaging>eclipse-plugin</packaging>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public boolean equals(Object arg0) {
*
* @since 4.3
*/
public static Comparator<ITimeEvent> WITHIN_COMPARATOR = (e1, e2) -> {
public static final Comparator<ITimeEvent> WITHIN_COMPARATOR = (e1, e2) -> {
int comp = Long.compare(e1.getTime(), e2.getTime());
if (comp > 0) {
return comp;
Expand Down

0 comments on commit 1086ae9

Please sign in to comment.