Skip to content

Commit

Permalink
callstack: Fix CallStackAnalysis format in Eclipse
Browse files Browse the repository at this point in the history
Change-Id: I70f8f3c84f470e5391160827f1a96fd6bc53c50f
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/197777
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
  • Loading branch information
marco-miller committed Jan 11, 2023
1 parent e86c29a commit 2e4ac02
Showing 1 changed file with 20 additions and 18 deletions.
Expand Up @@ -47,8 +47,11 @@
*/
public abstract class CallStackAnalysis extends TmfStateSystemAnalysisModule implements IFlameChartProvider, ICallGraphProvider {

/** CallStack stack-attribute
* @since 1.1*/
/**
* CallStack stack-attribute
*
* @since 1.1
*/
public static final String CALL_STACK = "CallStack"; //$NON-NLS-1$

private static final String[] DEFAULT_PROCESSES_PATTERN = new String[] { CallStackStateProvider.PROCESSES, "*" }; //$NON-NLS-1$
Expand Down Expand Up @@ -93,9 +96,10 @@ public String[] getProcessesPattern() {
}

/**
* Resolve the device ID if applicable. A device is the hardware context the trace is running
* on. An example would be CPU, GPU, DSP or even FPGA. This could allow device centric analyses
* such as the Callsite analysis to enrich the view.
* Resolve the device ID if applicable. A device is the hardware context the
* trace is running on. An example would be CPU, GPU, DSP or even FPGA. This
* could allow device centric analyses such as the Callsite analysis to
* enrich the view.
*
* @param quark
* quark of the state system to query
Expand All @@ -108,7 +112,6 @@ public String[] getProcessesPattern() {
return null;
}


/**
* Resolve the device type if applicable. A device is the hardware context
* the trace is running on. An example would be CPU, GPU, DSP or even FPGA.
Expand Down Expand Up @@ -231,8 +234,8 @@ public void dispose() {
}

/**
* Get the callstack host ID resolver for this instrumented series. The default
* is to use the host name of the trace.
* Get the callstack host ID resolver for this instrumented series. The
* default is to use the host name of the trace.
*
* @param trace
* The trace this analysis is run on
Expand All @@ -244,8 +247,8 @@ protected TraceHostIdResolver getCallStackHostResolver(ITmfTrace trace) {
}

/**
* Get the callstack TID resolver for this instrumented series. The default is
* to use the name of the second attribute as the thread ID.
* Get the callstack TID resolver for this instrumented series. The default
* is to use the name of the second attribute as the thread ID.
*
* @return The thread ID resolver
* @since 1.1
Expand Down Expand Up @@ -317,19 +320,18 @@ public ICallGraphProvider getCallGraph() {
}

/**
* Set whether the callgraph execution should be triggered automatically after
* building the callstack or if it should wait to be requested. This is used
* in benchmark to control when the callgraph module will be built.
* Set whether the callgraph execution should be triggered automatically
* after building the callstack or if it should wait to be requested. This
* is used in benchmark to control when the callgraph module will be built.
*
* @param trigger
* {@code true} means the callgraph analysis will be executed after
* the callstack, {@code false} means it will be executed on demand
* only.
* {@code true} means the callgraph analysis will be executed
* after the callstack, {@code false} means it will be executed
* on demand only.
* @since 1.1
*/
@VisibleForTesting
public void triggerAutomatically(boolean trigger) {
fAutomaticCallgraph = trigger;
}

}
}

0 comments on commit 2e4ac02

Please sign in to comment.