Skip to content

Commit

Permalink
os.linux: Move SWSLatencyAnalysis related classes to internal
Browse files Browse the repository at this point in the history
They should not have been public APIs in the first place when they were
released in Trace Compass 9.1.0.

Change-Id: I528042ec3406c5d44951497aaf55c1d3e57293ae
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/205079
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
  • Loading branch information
bhufmann committed Oct 24, 2023
1 parent 5676585 commit 84d54fa
Show file tree
Hide file tree
Showing 21 changed files with 69 additions and 32 deletions.
Expand Up @@ -22,12 +22,12 @@
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SchedWS;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SchedWS.InitialInfo;
import org.eclipse.tracecompass.analysis.os.linux.core.tests.Activator;
import org.eclipse.tracecompass.analysis.os.linux.core.tests.stubs.trace.TmfXmlKernelTraceStub;
import org.eclipse.tracecompass.analysis.os.linux.core.trace.IKernelTrace;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SchedWS;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SchedWS.InitialInfo;
import org.eclipse.tracecompass.segmentstore.core.ISegment;
import org.eclipse.tracecompass.segmentstore.core.ISegmentStore;
import org.eclipse.tracecompass.tmf.core.event.TmfEvent;
Expand Down
@@ -0,0 +1,35 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.tracecompass.analysis.os.linux.core" version="2">
<resource path="META-INF/MANIFEST.MF">
<filter comment="SWSLatencyAnalysis should not have been public API" id="923795461">
<message_arguments>
<message_argument value="8.2.0"/>
<message_argument value="8.1.0"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.Messages">
<filter comment="It should not have been API" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.Messages"/>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core_8.2.0"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
<filter comment="It should not have been API" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis"/>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core_8.2.0"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SchedWS">
<filter comment="It should not have been API" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SchedWS"/>
<message_argument value="org.eclipse.tracecompass.analysis.os.linux.core_8.2.0"/>
</message_arguments>
</filter>
</resource>
</component>
Expand Up @@ -36,7 +36,6 @@ Export-Package: org.eclipse.tracecompass.analysis.os.linux.core.contextswitch,
org.eclipse.tracecompass.analysis.os.linux.core.memory,
org.eclipse.tracecompass.analysis.os.linux.core.model,
org.eclipse.tracecompass.analysis.os.linux.core.signals,
org.eclipse.tracecompass.analysis.os.linux.core.swslatency,
org.eclipse.tracecompass.analysis.os.linux.core.tid,
org.eclipse.tracecompass.analysis.os.linux.core.trace,
org.eclipse.tracecompass.internal.analysis.os.linux.core;x-internal:=true,
Expand Down Expand Up @@ -65,6 +64,7 @@ Export-Package: org.eclipse.tracecompass.analysis.os.linux.core.contextswitch,
org.eclipse.tracecompass.analysis.callstack.core.tests",
org.eclipse.tracecompass.internal.analysis.os.linux.core.resourcesstatus;x-friends:="org.eclipse.tracecompass.analysis.os.linux.ui",
org.eclipse.tracecompass.internal.analysis.os.linux.core.segmentstore;x-friends:="org.eclipse.tracecompass.analysis.os.linux.ui",
org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency;x-friends:="org.eclipse.tracecompass.analysis.os.linux.core.tests,org.eclipse.tracecompass.analysis.os.linux.ui",
org.eclipse.tracecompass.internal.analysis.os.linux.core.threadstatus;
x-friends:="org.eclipse.tracecompass.analysis.callstack.core,
org.eclipse.tracecompass.analysis.os.linux.core.tests,
Expand Down
Expand Up @@ -89,7 +89,7 @@
</tracetype>
</module>
<module
analysis_module="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis"
analysis_module="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis"
applies_experiment="false"
automatic="false"
icon="icons/swslatency.png"
Expand Down
Expand Up @@ -15,9 +15,9 @@

import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.osgi.util.NLS;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.core.segmentstore.GenericSegmentStatisticsAnalysis;
import org.eclipse.tracecompass.analysis.timing.core.segmentstore.statistics.AbstractSegmentStatisticsAnalysis;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.internal.analysis.timing.core.segmentstore.AbstractSegmentStoreStatisticsDataProviderFactory;
import org.eclipse.tracecompass.segmentstore.core.ISegment;
import org.eclipse.tracecompass.tmf.core.analysis.IAnalysisModule;
Expand Down
Expand Up @@ -15,9 +15,9 @@

import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.osgi.util.NLS;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.core.segmentstore.GenericSegmentStatisticsAnalysis;
import org.eclipse.tracecompass.analysis.timing.core.segmentstore.statistics.AbstractSegmentStatisticsAnalysis;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.internal.analysis.timing.core.segmentstore.AbstractSegmentStoreStatisticsDataProviderFactory;
import org.eclipse.tracecompass.segmentstore.core.ISegment;
import org.eclipse.tracecompass.segmentstore.core.segment.interfaces.INamedSegment;
Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.core.swslatency;
package org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency;

import org.apache.commons.lang3.StringUtils;
import org.eclipse.jdt.annotation.Nullable;
Expand All @@ -23,7 +23,7 @@
*/
public class Messages extends NLS {

private static final String BUNDLE_NAME = "org.eclipse.tracecompass.analysis.os.linux.core.swslatency.messages"; //$NON-NLS-1$
private static final String BUNDLE_NAME = "org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.messages"; //$NON-NLS-1$

/** Sched_Wakeup/Sched_switch TID aspect help text */
public static @Nullable String SegmentAspectHelpText_SWSTid;
Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.core.swslatency;
package org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency;

import java.util.Collection;
import java.util.Comparator;
Expand Down Expand Up @@ -124,7 +124,7 @@ public void handleData(ITmfEvent event) {
long startTime = event.getTimestamp().toNanos();
String threadName = event.getContent().getFieldValue(String.class, layout.fieldComm());

if (threadName == null || "".equals(threadName)) {
if (threadName == null || "".equals(threadName)) { //$NON-NLS-1$
threadName = "UNKNOWN"; //$NON-NLS-1$
}

Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.core.swslatency;
package org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency;

import org.eclipse.tracecompass.analysis.os.linux.core.model.OsStrings;
import org.eclipse.tracecompass.datastore.core.interval.IHTIntervalReader;
Expand Down
Expand Up @@ -9,4 +9,4 @@
*******************************************************************************/

@org.eclipse.jdt.annotation.NonNullByDefault
package org.eclipse.tracecompass.analysis.os.linux.core.swslatency;
package org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency;
Expand Up @@ -28,6 +28,7 @@ Import-Package: com.google.common.annotations,
Export-Package: org.eclipse.tracecompass.internal.analysis.os.linux.ui;x-friends:="org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests",
org.eclipse.tracecompass.internal.analysis.os.linux.ui.actions;x-friends:="org.eclipse.tracecompass.analysis.callstack.ui",
org.eclipse.tracecompass.internal.analysis.os.linux.ui.perspectives;x-internal:=true,
org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics;x-internal:=true,
org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.controlflow;
x-friends:="org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests,
org.eclipse.tracecompass.analysis.os.linux.ui.tests,
Expand All @@ -43,5 +44,6 @@ Export-Package: org.eclipse.tracecompass.internal.analysis.os.linux.ui;x-friends
x-friends:="org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests,
org.eclipse.tracecompass.analysis.os.linux.ui.tests,
org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests,
org.eclipse.tracecompass.lttng2.kernel.ui"
org.eclipse.tracecompass.lttng2.kernel.ui",
org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.swslatency;x-internal:=true
Automatic-Module-Name: org.eclipse.tracecompass.analysis.os.linux.ui
20 changes: 10 additions & 10 deletions analysis/org.eclipse.tracecompass.analysis.os.linux.ui/plugin.xml
Expand Up @@ -31,7 +31,7 @@
</view>
<view
category="org.eclipse.linuxtools.tmf.ui.views.category"
class="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.PriorityThreadNameStatisticsView"
class="org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics.PriorityThreadNameStatisticsView"
icon="icons/eview16/statistics_view.gif"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.prioname"
name="%view.segstore.statistics.prioname"
Expand All @@ -40,15 +40,15 @@
<view
allowMultiple="false"
category="org.eclipse.linuxtools.lttng2.ui.views.category"
class="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.PriorityThreadNameStatisticsView"
class="org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics.PriorityThreadNameStatisticsView"
icon="icons/obj16/statistics_view.gif"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.prioname:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws"
name="%swslatency.stats.view.name.prioname"
restorable="true">
</view>
<view
category="org.eclipse.linuxtools.tmf.ui.views.category"
class="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.PriorityStatisticsView"
class="org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics.PriorityStatisticsView"
icon="icons/eview16/statistics_view.gif"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.priority"
name="%view.segstore.statistics.priority"
Expand All @@ -57,7 +57,7 @@
<view
allowMultiple="false"
category="org.eclipse.linuxtools.lttng2.ui.views.category"
class="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.PriorityStatisticsView"
class="org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics.PriorityStatisticsView"
icon="icons/obj16/statistics_view.gif"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.priority:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws"
name="%swslatency.stats.view.name.priority"
Expand Down Expand Up @@ -218,42 +218,42 @@
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.analysis.timing.ui.segstore.table:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
<output
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.swslatency.scatter">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
<output
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.analysis.timing.ui.segstore.statistics:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
<output
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.prioname:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
<output
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics.priority:org.eclipse.tracecompass.analysis.os.linux.core.swslatency.sws">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
<output
class="org.eclipse.tracecompass.tmf.ui.analysis.TmfAnalysisViewOutput"
id="org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.swslatency.density">
<analysisModuleClass
class="org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
class="org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis">
</analysisModuleClass>
</output>
</extension>
Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
**********************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics;
package org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics;

import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
**********************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics;
package org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics;

import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.statistics.AbstractSegmentsStatisticsViewer;
Expand Down
Expand Up @@ -9,7 +9,7 @@
* SPDX-License-Identifier: EPL-2.0
**********************************************************************/

package org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics;
package org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics;

import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
Expand Down
Expand Up @@ -8,7 +8,7 @@
*
* SPDX-License-Identifier: EPL-2.0
**********************************************************************/
package org.eclipse.tracecompass.analysis.os.linux.ui.segmentstore.statistics;
package org.eclipse.tracecompass.internal.analysis.os.linux.ui.segmentstore.statistics;

import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.statistics.AbstractSegmentsStatisticsViewer;
Expand Down
Expand Up @@ -13,9 +13,9 @@

import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.core.segmentstore.ISegmentStoreProvider;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.density2.AbstractSegmentStoreDensityViewer;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.tmf.core.trace.ITmfTrace;
import org.eclipse.tracecompass.tmf.core.trace.TmfTraceUtils;

Expand Down
Expand Up @@ -14,11 +14,11 @@
import org.eclipse.jface.viewers.TableViewer;
import org.eclipse.swt.SWT;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.density2.AbstractSegmentStoreDensityView;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.density2.AbstractSegmentStoreDensityViewer;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.table.AbstractSegmentStoreTableViewer;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.table.SegmentStoreTableViewer;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;

/**
* Sched_wakeup / sched_switch Density view
Expand Down
Expand Up @@ -12,8 +12,8 @@
package org.eclipse.tracecompass.internal.analysis.os.linux.ui.views.swslatency;

import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.scatter.AbstractSegmentStoreScatterChartViewer2;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.tmf.ui.viewers.xychart.linechart.TmfXYChartSettings;

/**
Expand Down
Expand Up @@ -18,8 +18,8 @@
import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.tracecompass.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.scatter.AbstractSegmentStoreScatterChartTreeViewer2;
import org.eclipse.tracecompass.internal.analysis.os.linux.core.swslatency.SWSLatencyAnalysis;
import org.eclipse.tracecompass.tmf.ui.viewers.TmfViewer;
import org.eclipse.tracecompass.tmf.ui.viewers.xychart.TmfXYChartViewer;
import org.eclipse.tracecompass.tmf.ui.views.xychart.TmfChartView;
Expand Down

0 comments on commit 84d54fa

Please sign in to comment.