Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: bpdm document update for QG4 23.12 #620

Merged

Conversation

SujitMBRDI
Copy link
Contributor

@SujitMBRDI SujitMBRDI commented Nov 15, 2023

Description

In this pull request, update documentation for BPDM which is needed for quality gate 4

Fixes #562

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI force-pushed the doc/quality_gate_updates_23.12 branch 2 times, most recently from 9c4f231 to ea1dce0 Compare November 15, 2023 09:49
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good but the versioning of the chart needs to be fixed. The version of the cleaning-service-chart needs to incremented as well

(Interesting that Chart linting didn't detect anything. Seems to be a weakness in our check here)

@SujitMBRDI
Copy link
Contributor Author

Content looks good but the versioning of the chart needs to be fixed. The version of the cleaning-service-chart needs to incremented as well

(Interesting that Chart linting didn't detect anything. Seems to be a weakness in our check here)

Ok, when i made first changes chart linting thrown error to bump umbrella chart version not others so i made changes in umbrella chart but will adapt those changes

@nicoprow nicoprow merged commit c7040d8 into eclipse-tractusx:main Nov 17, 2023
9 checks passed
@nicoprow nicoprow deleted the doc/quality_gate_updates_23.12 branch November 17, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Cleaning Service Dummy
2 participants