Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pool): Added Street Name Additional Fields information #685

Merged
merged 1 commit into from
Jan 3, 2024
Merged

feat(pool): Added Street Name Additional Fields information #685

merged 1 commit into from
Jan 3, 2024

Conversation

cezaralexandremorais
Copy link
Contributor

Added Street Name Additional Fields information

Solves #673

nicoprow
nicoprow requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@nicoprow nicoprow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Model looks good.

Testing the values is missing. I would expect the new street names added to the test values.

@nicoprow nicoprow force-pushed the feat/Street_Name_Additional_Fields branch from da43868 to 6b6c7e1 Compare January 3, 2024 04:13
@nicoprow nicoprow merged commit 3c795a8 into eclipse-tractusx:main Jan 3, 2024
9 checks passed
@nicoprow nicoprow deleted the feat/Street_Name_Additional_Fields branch January 3, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoprow nicoprow nicoprow approved these changes

@martinfkaeser martinfkaeser Awaiting requested review from martinfkaeser

@fabiodmota fabiodmota Awaiting requested review from fabiodmota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cezaralexandremorais @nicoprow