fix(Cleaning-Service-Dummy): missing confidence criteria #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic business partner
nicoprow
force-pushed
the
fix/confidence-criteria-missing
branch
from
a53692d
to
b543097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the missing confidence criteria in the generic business partner. Basically the cleaning service now additionally to LSA also adds the confidence criteria to the generic business partner. This way when Gate requests the business partner data from the Orchestrator it will also find the confidence criteria there.
On the same note I also made the cleaning service add the correct address type to the generic business partner. So now it should never be null, even if it was not provided by the sharing member.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: