Release/v0.6.0: Redesign of Battery Passport #16

matbmoser · 2023-04-24T14:07:18Z

PR part of release v0.6.0, Sub Release v0.6.0.0

Why we create this PR?

To merge the new redesign passport changes

What we want to achieve with this PR?

Upgrade the actual design of the passport

What is new?

Added

Refactor the UI according to the designs given by Accenture
Implemented new User Interface (UI) design for battery passport page

fix: fixed backend configuration, re-enable response indent

…-passport

…ry-passport Release/v0.6.0.0: Merge redesign battery pass

gitguardian · 2023-04-24T14:07:55Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}}

SebastianBezold

You do have a lot of copyright header findings again. Please use your IDE capabilities. It just takes too much time for a task, that could have been automated

SebastianBezold · 2023-04-27T14:30:38Z

src/assets/styles/components/passport/cards.scss

Copyright and License Header missing. Consider to use your IDE capabilities to auto-add them on new files

SebastianBezold · 2023-04-27T14:31:10Z

src/assets/styles/components/passport/elementChart.scss

Copyright + License header

SebastianBezold · 2023-04-27T14:31:28Z

src/assets/styles/components/passport/field.scss

Header again

SebastianBezold · 2023-04-27T14:31:36Z

src/assets/styles/components/passport/passportPage.scss

SebastianBezold · 2023-04-27T14:32:46Z

src/components/passport/BarChart.vue

This license header does not seem to be complete.
At lease SPDX identifier missing. Eclipse contributors part missing

SebastianBezold · 2023-04-27T14:33:00Z

src/components/passport/Cards.vue

Again incomplete header

SebastianBezold · 2023-04-27T14:33:24Z

src/components/passport/ElementChart.vue

Incomplete header

SebastianBezold · 2023-04-27T14:44:15Z

@matbmoser can you also please ask someone to do a content review, since I cannot review the CSS and JavaScript changes.
Comments about the GitGuardian findings are also appreciated if you already analyzed them

matbmoser · 2023-04-27T18:59:07Z

You do have a lot of copyright header findings again. Please use your IDE capabilities. It just takes too much time for a task, that could have been automated

@SebastianBezold We are aware of that... Unfortunately not all our developers have an automatic header license configured so we need to revise all manually and sometimes some files scape our control. They will be fixed. I will be reminding them to integrate the IDE header licenser.

matbmoser · 2023-04-28T09:05:20Z

#16 (comment)

GitGuardian is detecting false positives in the values.yaml

SebastianBezold · 2023-04-28T09:13:21Z

You do have a lot of copyright header findings again. Please use your IDE capabilities. It just takes too much time for a task, that could have been automated

@SebastianBezold We are aware of that... Unfortunately not all our developers have a automatic header license so we need to revise all manually and sometimes some files scape our control. They will be fixed. I will be reminding them to integrate the IDE header licenser.

Is there any advice, that you can generally share? I could show you how i configured my IDEs from the JetBrains family. Not sure about VS Code in case you use that

matbmoser · 2023-04-28T09:15:54Z

#16 (comment)

@SebastianBezold I will ask the question today in the DevSecOps meeting, I have it configured in Intelij however mostly we use VSCode and the structure by the plugins provided limits us (because it does not includes the SPDX field and the license notice at the same time)

matbmoser · 2023-04-28T09:34:21Z

@SebastianBezold I just created a open discussion about that in the tractus-x dev mailing list, so we can find the best practices in this case.

matbmoser · 2023-04-28T15:22:37Z

@SebastianBezold we solved the necessary fixes for the license headers in the last PR from the version v0.6.0 -> #24
Please review the PR and let us know your feedback.

saudkhan116 · 2023-04-28T15:25:25Z

Hi @SebastianBezold, I have reviewed the JavaScript and CSS content and they are fine and ready for the release v0.6.0.

matbmoser · 2023-05-03T15:18:48Z

Sub release strategy (slit bigger releases) proposed by the System Team failed to work, because of lack of tracking and the lack of rebase possibilities. https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

The new commit strategy will follow this diagram from gitflow:

SebastianBezold · 2023-05-03T15:31:03Z

Merging without copyright headers, but tracking in #24

Changes will be introduces in later PR

davidzynda and others added 19 commits March 15, 2023 11:42

sub-task cmp-544 header + font import + MOCK

afa3c7a

cmp-546 passport header + backBtn + ID + shareBtn

7eba0de

WIP: Card component

473a421

Cards component refactor

a644cb1

barChart + WIP: General Information

b30a942

Merge pull request #36 from catenax-ng/bugfix/backend-configu

1c56acb

fix: fixed backend configuration, re-enable response indent

WiP: State of Battery

52ed908

WiP: Cell chem | Elelctro prop | Additional inf

86f7f2c

Contract info + scss refactor + BarChart

3d5e2a4

refactor

0de5270

Merge branch 'develop' into feature/cmp-465/redesign-battery-passport

7fd7917

update: added changes from develop, skip merge updates

446dddc

update: merged changes from redesing battery passport

600046a

review fixes

22cdf99

fix: fixed card responsiveness, fixed state of battery fields

4695800

header size fix | Cards fix

00f426c

fix: dynamic adapt to extreme data

b2e04d9

Merge branch 'release/v0.6.0.0' into feature/cmp-465/redesign-battery…

27c6fee

…-passport

Merge pull request #57 from catenax-ng/feature/cmp-465/redesign-batte…

dd6bb39

…ry-passport Release/v0.6.0.0: Merge redesign battery pass

matbmoser marked this pull request as draft April 24, 2023 14:07

matbmoser mentioned this pull request Apr 24, 2023

Release/v0.6.0: Documentation and Bugfixes from Redesign Battery Pass #17

Merged

saudkhan116 mentioned this pull request Apr 24, 2023

Sub-Release 2: Release/v0.6.0: Include 404 Page + documentation + stability of the application #18

Merged

This was referenced Apr 24, 2023

Release/v0.6.0: Improve robustness of passport viewer #19

Closed

Release/v0.6.0: Improve responsiveness + Resolved Bugs #20

Merged

Release/v0.6.0: Security Vulnerabilities Mitigated + Release 0.6.0 Final Documentation #21

Merged

matbmoser changed the title ~~Release/v0.6.0.0: Redesign Battery Passport~~ Release/v0.6.0.0: Redesign of Battery Passport Apr 24, 2023

matbmoser marked this pull request as ready for review April 26, 2023 07:26

SebastianBezold previously requested changes Apr 27, 2023

View reviewed changes

matbmoser changed the title ~~Release/v0.6.0.0: Redesign of Battery Passport~~ Release/v0.6.0: Redesign of Battery Passport Apr 28, 2023

matbmoser changed the title ~~Release/v0.6.0: Redesign of Battery Passport~~ Part 2: Release/v0.6.0: Redesign of Battery Passport Apr 28, 2023

matbmoser changed the title ~~Part 2: Release/v0.6.0: Redesign of Battery Passport~~ Sub-Release 1: Release/v0.6.0: Redesign of Battery Passport Apr 28, 2023

matbmoser changed the title ~~Sub-Release 1: Release/v0.6.0: Redesign of Battery Passport~~ Sub-Release 0: Release/v0.6.0: Redesign of Battery Passport Apr 28, 2023

matbmoser mentioned this pull request Apr 28, 2023

Release/v0.6.0: Updated and Added license headers #24

Merged

matbmoser requested a review from SebastianBezold April 28, 2023 15:28

matbmoser closed this May 3, 2023

matbmoser reopened this May 3, 2023

SebastianBezold merged commit f3799dc into eclipse-tractusx:main May 3, 2023
2 of 4 checks passed

SebastianBezold deleted the release/v0.6.0.0 branch May 3, 2023 15:31

matbmoser changed the title ~~Sub-Release 0: Release/v0.6.0: Redesign of Battery Passport~~ Release/v0.6.0: Redesign of Battery Passport May 3, 2023

matbmoser added the enhancement New feature or request label May 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/v0.6.0: Redesign of Battery Passport #16

Release/v0.6.0: Redesign of Battery Passport #16

matbmoser commented Apr 24, 2023 •

edited

gitguardian bot commented Apr 24, 2023 •

edited

SebastianBezold left a comment

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold Apr 27, 2023

SebastianBezold commented Apr 27, 2023

matbmoser commented Apr 27, 2023 •

edited

matbmoser commented Apr 28, 2023

SebastianBezold commented Apr 28, 2023

matbmoser commented Apr 28, 2023 •

edited

matbmoser commented Apr 28, 2023 •

edited

matbmoser commented Apr 28, 2023

saudkhan116 commented Apr 28, 2023 •

edited

matbmoser commented May 3, 2023 •

edited

SebastianBezold commented May 3, 2023

Release/v0.6.0: Redesign of Battery Passport #16

Release/v0.6.0: Redesign of Battery Passport #16

Conversation

matbmoser commented Apr 24, 2023 • edited

PR part of release v0.6.0, Sub Release v0.6.0.0

Why we create this PR?

What we want to achieve with this PR?

What is new?

Added

gitguardian bot commented Apr 24, 2023 • edited

️✅ There are no secrets present in this pull request anymore.

SebastianBezold left a comment

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold Apr 27, 2023

Choose a reason for hiding this comment

SebastianBezold commented Apr 27, 2023

matbmoser commented Apr 27, 2023 • edited

matbmoser commented Apr 28, 2023

SebastianBezold commented Apr 28, 2023

matbmoser commented Apr 28, 2023 • edited

matbmoser commented Apr 28, 2023 • edited

matbmoser commented Apr 28, 2023

saudkhan116 commented Apr 28, 2023 • edited

matbmoser commented May 3, 2023 • edited

SebastianBezold commented May 3, 2023

matbmoser commented Apr 24, 2023 •

edited

gitguardian bot commented Apr 24, 2023 •

edited

matbmoser commented Apr 27, 2023 •

edited

matbmoser commented Apr 28, 2023 •

edited

matbmoser commented Apr 28, 2023 •

edited

saudkhan116 commented Apr 28, 2023 •

edited

matbmoser commented May 3, 2023 •

edited