Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.3.0 refactor directory structure: Clean up unnecessary files and restructure repo #259

Conversation

saudkhan116
Copy link
Contributor

Why we create this PR?

This PR contains the following refactoring changes:

Cleaned unnecessary/unused files/directories/docs/images.

  • removed environment-specific values files i.e., -dev and values-beta files from helm charts
  • removed specific occurence of ArgoCD Hotelbudapest
  • renamed Keycloak to IAM and removed the docker directory
  • refactored workflows where necessary
  • made the dpp-frontend into one directory
  • made data-service as standalone service (took it out from the edc-provider)
  • organized data-consumer and data-provider artifacts

What we want to achieve with this PR?

The DPP git repository structure must follow the standardised open-source project structure.

What is new?

Updated

Refactored the follwoing files:

  • refactored workflows where necessary
  • made the dpp-frontend into one directory
  • made data-service as standalone service (took it out from the edc-provider)
  • renamed Keycloak to IAM and removed the docker directory
  • organized data-consumer and data-provider artifacts
  • re-organized directory strcuture of docs and deployment folders

Deleted

  • Deleted unused files/directories/docs/images
    • removed environment-specific values files from helm charts
    • removed specific infrastructure guide

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification of why there are so much changes:

We cleaned the repository of unnecessary things, also the folder structure was re-done to simplify the organization of the different components in the respository and fit with the general structure that other respositories are also folllowing like "Item Relationship Service" or "Tractus-X Connector"

No extra IP check needs to be done since all the content was already there, and just the renaming of images, and creating folders and moving documentation also is no content change just organization.

@saudkhan116 saudkhan116 changed the title Release/3.0.0 refactor directory structure: Clean up unnecessary files and restructure repo Release/2.3.0 refactor directory structure: Clean up unnecessary files and restructure repo Apr 9, 2024
@saudkhan116 saudkhan116 merged commit 754c97e into eclipse-tractusx:main Apr 16, 2024
7 checks passed
@saudkhan116 saudkhan116 deleted the release/3.0.0-refactor-directory-structure branch April 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants