Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce Digital Twin KIT #287

Merged
merged 12 commits into from
Jul 12, 2023
Merged

feat: Introduce Digital Twin KIT #287

merged 12 commits into from
Jul 12, 2023

Conversation

arnoweiss
Copy link
Contributor

Description

This PR introduces the Digital Twin KIT as a bundle of all Digital-Twin-related content in Catena-X. It covers the AAS-Discovery-Cycle and will in the future hold more detailed best-practices on cross-use-case issues like AAS-EDC integration.

Additional information

I don't think copyright headers and dependency update checks apply here as this is merely added documentation.

thomas-henn
thomas-henn reviewed Jul 7, 2023
View reviewed changes
docs-kits/kits/Digital Twin Kit/page_adoption-view.md
- Well-defined API structure extensible by domain models. Each use-case will want to share different data and the API
expands with the scope of the model.

- A distributed infrastructure of central and decentral components integrating hand-in-hand with backend-systems southward
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sentence might need further explanation via a pciture in the future.

thomas-henn
thomas-henn reviewed Jul 7, 2023
View reviewed changes
Copy link

@thomas-henn thomas-henn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some suggestions for syntax. Please adjust these.
Especially, at most, it is not clear to me, why you are using capital letters.
One (short) paragraph was really hard to understand. Please rewrite that.
Overall, it is a document to start with, even though, readers might be interested in more details in future.

@arnoweiss arnoweiss marked this pull request as ready for review July 11, 2023 06:11
@arnoweiss
Copy link
Contributor Author

Ready to merge.
@danielmiehle, @santiagoejm please assign a formal reviewer from tractusx.

@danielmiehle danielmiehle merged commit 6bfdfaf into eclipse-tractusx:main Jul 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-henn thomas-henn thomas-henn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnoweiss @thomas-henn @danielmiehle