Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/about page header #33

Closed
wants to merge 7 commits into from

Conversation

santiagoejm
Copy link
Contributor

The AboutUsHeader component is been defined at the src/components folder & been used in the new src/pages/AboutUs page.

Note: the route to the About Us Page it's not yet been defined in the docusaurus.config.js file, only manual access to this page is possible at the moment though the url: /aboutus

The result of the header is:

Screenshot 2022-12-15 at 17 34 42

}



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new PR and remove too many new lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siegfriedk noted! creating new one right away

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to conflicts @Siegfriedk I see now why a complete new PR is requested :/

Copy link
Contributor

@Siegfriedk Siegfriedk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background image is WAAAY to big.

its over a megabyte and a 5 second online compression here https://imagecompressor.com/ already reduces it to 500kb

danielmiehle pushed a commit that referenced this pull request Mar 6, 2024
docs(ic): updated software development view after initial creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants