fix: connector kit structural overhaul #346
Conversation
There was a problem hiding this comment.
Hey @bcronin90 ,
I really like the idea of simplifying this process :)
However, the PR is very difficult to review. The following suggestions:
- Use the Markdownlinter and fix all issues.
- Delete all unnecessary files (jquery.md etc)
- please check you eca, otherwise we will get issues
Have you looked at the change locally? How does the structure look compared to the original?
...r Kit/Development View/03_EDC Controlplane/edc-controlplane-memory-hashicorp-vault/notice.md
Outdated
Show resolved
Hide resolved
...t/Development View/03_EDC Controlplane/edc-runtime-memory/build/docs/javadoc/legal/jquery.md
Outdated
Show resolved
Hide resolved
stephanbcbauer
added
documentation
bcronin90
force-pushed
the
docs/new-connector-structure
branch
from
db936c2
to
666499a
Compare
|
@bcronin90 can this PR be closed :) Because of the ECA issue we can never ever merge it |
I'd rather we fix the issues and eventually merge it. Or should we just abort all the restructuring and keep doing all this by hand? |
Yes we should definitly fix it, but with this PR we will never be able to merge it, cause at least one commit was done with an account (mail) which is not mapped to the ECA. |
|
I see. I'll need to change the commit history then, PR should be good. I'll look into it when I'm back. |
bcronin90
force-pushed
the
docs/new-connector-structure
branch
2 times, most recently
from
ce94cba
to
a185fee
Compare
|
@stephanbcbauer That should have resolved all the technical hurdles. Now we just need to be sure the contents are sound. |
bcronin90
force-pushed
the
docs/new-connector-structure
branch
from
68fd7f1
to
91af721
Compare
|
@stephanbcbauer Are you up for a review? |
bcronin90
force-pushed
the
docs/new-connector-structure
branch
from
91af721
to
ea27471
Compare
Signed-off-by: Brendan Cronin <brendan.cronin@mercedes-benz.com>
Signed-off-by: Brendan Cronin <brendan.cronin@mercedes-benz.com>
Signed-off-by: Brendan Cronin <brendan.cronin@mercedes-benz.com>
This reverts commit 45f8b69.
bcronin90
force-pushed
the
docs/new-connector-structure
branch
from
55dd1d4
to
cddb947
Compare
|
@bcronin90 will check it this week. The review will take some time, cause i have to build it locally and compare the structure with the old one. Will come back to you, after i checked it. Thanks for your patience |
|
We still have to wait a little bit. There is an open discussion related to this topic #448 |
Description
Enhances documentation process by simplifying Connector Kit documentation to a single directory (and an openapi yaml, for now).
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
These changes should not impact the two checks above. Can somebody sanity check this?