Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/dt/prep 24 05 #850

Merged
merged 15 commits into from
May 23, 2024
Merged

Conversation

arnoweiss
Copy link
Contributor

@arnoweiss arnoweiss commented Apr 17, 2024

Description

follow-up to #815

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@arnoweiss
Copy link
Contributor Author

Someone please review this 😭

@SebastianBezold
Copy link
Contributor

Someone please review this 😭

Unfortunately, I cannot provide feedback to any of the changes. Not really into the topic

@SebastianBezold SebastianBezold removed their request for review May 2, 2024 10:07
@FaGru3n
Copy link
Contributor

FaGru3n commented May 2, 2024

Someone please review this 😭

Hi @arnoweiss me neither... 😅

@FaGru3n FaGru3n removed their request for review May 2, 2024 10:43
Copy link

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@tunacicek tunacicek self-requested a review May 14, 2024 08:47
Copy link

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since my comments from #779 are implemented.

@arnoweiss arnoweiss merged commit 2963d4a into eclipse-tractusx:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants