-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R 24.05. Behaviour Twin KIT (v1.0.0) added, Remaining useful Life KIT and Health Indicator KIT removed #889
R 24.05. Behaviour Twin KIT (v1.0.0) added, Remaining useful Life KIT and Health Indicator KIT removed #889
Conversation
…tion finished, Development View and Use Cases need some more work. Health Indicator KIT and Remaining useful Life KIT removed (integrated into Behaviour Twin KIT).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good revision of the KIT. Good description, especially how to start new use cases and the required resources.
Please add the missing legal notice sections. The remaining comments are only minor notes.
|
||
### OVERVIEW | ||
|
||
A use case consists of data and calculation services. In addition, a logic is required, that defines how data and services must interact to produce the desired result. This logic is called "skill". It must be invoked directly or indirectly by the consumer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add a link to definition of a "skill" in the Agent KIT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will write a short definition of skills in the Adoption View/Knowledge Agent page. There, we will reference to the definition at the Agents KIT (href=docs-kits/next/kits/knowledge-agents/development-view/modelling#skill).
@@ -0,0 +1,208 @@ | |||
--- | |||
id: architecture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require a big change of our structure. We prefer to leave it as is. The contents build on each other, so we need less cross-references. This makes the KIT more easy to read.
@@ -0,0 +1,37 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this section! However, does it make sense to move it rather to the development view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would prefer to leave it in the Adoption View. The content referes to general steps like joining Catena-X as well as development-specific steps.
@@ -0,0 +1,78 @@ | |||
--- | |||
id: terminology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jSchuetz88 : Input for the overarching glossary!
https://catenax-ev.github.io/docs/next/working-model/glossary
|
||
- ./. | ||
|
||
### CHANGED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no content has been changed or deleted, I would leave out the bullet points.
What is the difference between KIT and Use Cases? Do we need this distinction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be done. The destinction should be preserved because use cases may be developed independently of the general part of the KIT. This provides a better overview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -0,0 +1,37 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AngelikaWittek: Can you please help if this PR needs an Eclipse IP check (e.g. over 1000 loc)?
Background: Two KITs were merged into one KIT. Therefore, nothing has changed in terms of content - only the structure has been restructured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some additional/revised code blocks (e.g. skills). These are provided by the Agents KIT (the new/next Agents KIT version 24-05 will contain all the examples). We added the contributors at the legal notice(s) and they are mentioned in the headers of the code blocks.
@@ -0,0 +1,37 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to also move it rather to the development view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…nt View as well as to the overview pages of the use cases section. Moved guidance page to Development View. Described skills and shapes graphs in more detail. Added diagrams for better description of role combinations. Added extended description with diagrams to the benefits in the Adoption View. Some minor corrections.
…duction to Knowledge Agent section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great addition and simplified user guidance through the one KIT structure - minor change requests, then good to go!
|
||
![supply chain visibility](assets/supply-chain-visibility.drawio.svg) | ||
|
||
To engage additional actors in the supply chain, the framework agreements and other requirements must be propagated through the chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very broad statement - especially on one up one down - I would prefer that per definition we keep one up one down. Individual agreements are possible, but per design, Catena-X does not foresee breaking out of this guideline.
I know that for BT we had not managed to finalize the predefined use case framework yet, but you could still link here for the general page where those are listed:
https://catena-x.net/en/catena-x-introduce-implement/governance-framework-for-data-space-operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised the description.
</div> | ||
</div> | ||
|
||
## CATENA-X RELEASES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this section completely as it is not KIT-specific- Catena-X Release Management is handled in the CX Association - I would broadly defer to the CX Website.
If you do want to keep it in, please rename "main" into "major".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised the description and moved it into the To Be Considered page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not getting a picture displayed here - intentional or technical error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the svg file and used instead the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not getting a picture displayed here - intentional or technical error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs-kits/kits/behaviour-twin-kit/use-cases/hi/development-view/service-bindings.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/behaviour-twin-kit/use-cases/rul/development-view/service-bindings.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/behaviour-twin-kit/use-cases/rul/development-view/skill.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too. In addition to the other comments, only minor remarks from my side.
description: Behaviour Twin KIT | ||
--- | ||
|
||
<div style={{fontSize:30, color:'rgb(255,166,1)', marginBottom:13}}>Behaviour Twin KIT -- Remaining useful Life</div> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, I set hide_title: true.
HTML is used to provide color for that special headline. # would not work because it would be a multiple top level headline. By setting hide_title: true, I got rid of the redundant headline now.
docs-kits/kits/behaviour-twin-kit/use-cases/rul/development-view/skill.md
Outdated
Show resolved
Hide resolved
|
||
![business-process](assets/business-process.drawio.svg) | ||
|
||
0. **sync federated catalog:** <br/> The federated catalogs are synchronized periodically. As a result, the OEM can resolve RuL prognosis function assets that are located at the supplier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark: Markdown notation / linebreaks should be preferred to an HTML-tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The desired result (line break within a list element) is not possible without HTML as I know. If there is a better solution, please let me know.
docs-kits/kits/behaviour-twin-kit/use-cases/hi/adoption-view/overview.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/behaviour-twin-kit/development-view/guidance-and-resources.md
Outdated
Show resolved
Hide resolved
…moved contents into to-be-considered section. Updated all copyright dates to 2024.
Description
Added
new KIT: Behaviour Twin KIT, version 1.0.0.
Removed