Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename credential offers to notifications and define proof-of-possesion methodolgy #11

Closed
jimmarino opened this issue Sep 21, 2023 · 5 comments
Milestone

Comments

@jimmarino
Copy link
Contributor

For @borisrizov-zf

We decided to rename credential offers to credential notifications and include a proof-of-posession feature for sending notifications.

@borisrizov-zf
Copy link
Contributor

@jimmarino There seems to be a double key entry credentials in section 4.1.1 can you take a look and advise. Also the sentence in the first occurrence is incomplete, should I just consolidate them?

@jimmarino
Copy link
Contributor Author

I think that is a merge error. Can you clean that up as part of this PR?

@borisrizov-zf
Copy link
Contributor

@jimmarino one more thing, do you remember what we decided for the keys in json? camelCase or snake_case?

@jimmarino
Copy link
Contributor Author

@jimmarino one more thing, do you remember what we decided for the keys in json? camelCase or snake_case?

I can't remember exactly but DSP uses camel case and since we are planning on contributing these specs there at some point, it may make sense to adopt that convention.

@borisrizov-zf
Copy link
Contributor

@jimmarino one more thing, do you remember what we decided for the keys in json? camelCase or snake_case?

I can't remember exactly but DSP uses camel case and since we are planning on contributing these specs there at some point, it may make sense to adopt that convention.

Ok, I'll do that then. Maybe we should have a quick chat, because I've got some other questions, are you on matrix?

@paullatzelsperger paullatzelsperger added this to the 0.8.1 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants