Feature/639 policy store api paging #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint Filtering is still missing
…wn service in order to avoid PolicyStoreService becoming a god-class
…vements still missing: - filtering for validUntil and createdOn - documentation, further / adjustment of tests, see TODOs with eclipse-tractusx#639
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * Search criteria. | ||
| * | ||
| * @param <T> type for value |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
9 tasks
…ermission for sorting / filtering
- complexity of getPolicyComparator not reducible (we need if branch for each field) - static imports in these classes make them more readable
…operation for createdOn and validUntil According to discussion instead of BETWEEN operation there will be the operations AFTER_LOCAL_DATE and BEFORE_LOCAL_DATE. These will be implemented in a later story.
|
Hi @ds-jhartmann,
|
ds-jhartmann
approved these changes
Jul 5, 2024
dsmf
force-pushed
the
feature/639-policy-store-api-paging
branch
from
47a5906
to
a3435f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: