Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incorporate small findings from qgate review #145

Merged
merged 5 commits into from
May 21, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented May 20, 2024

Description

During Review of the QGate #127, a few things were that small that I directly incorporated them.

Why

Compliance to TRG is needed. Beside the issues listed, I added the QGate check workflow so that you automate a few checks a little :)

Issue

Following issues are resolved:

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title Chore/qgate review small findings chore: incorporate small findings from qgate review May 20, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the PR, really handy :)
Just one comment.

charts/policy-hub/README.md Outdated Show resolved Hide resolved
@evegufy evegufy mentioned this pull request May 21, 2024
37 tasks
@evegufy evegufy changed the base branch from main to release/v1.0.0 May 21, 2024 15:29
@evegufy evegufy merged commit d68b124 into release/v1.0.0 May 21, 2024
7 checks passed
@evegufy evegufy deleted the chore/qgate-review-small-findings branch May 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants