feat(selfDescription)!: selfDescriptionDocument can be send as json #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil91
added
the
merge postponed
ntruchsess
requested changes
Jun 28, 2023
src/externalsystems/SdFactory.Library/BusinessLogic/SdFactoryBusinessLogic.cs
Outdated
Show resolved
Hide resolved
Phil91
force-pushed
the
feature/CPLP-2847-selfDescription
branch
from
b08a595
to
3f925bd
Compare
ntruchsess
previously approved these changes
Jun 29, 2023
ntruchsess
added
the
breaking change
Phil91
force-pushed
the
feature/CPLP-2847-selfDescription
branch
from
3f925bd
to
f40a33d
Compare
the data structure for the endpoints /api/administration/Connectors/clearinghouse/selfDescription /api/administration/registration/clearinghouse/selfDescription have been changed for selfDescriptionDocument from string to JsonDocument Refs: CPLP-2847 BREAKING CHANGE: data structure for endpoints changed
Refs: CPLP-2847
ntruchsess
force-pushed
the
feature/CPLP-2847-selfDescription
branch
4 times, most recently
from
4e16bc4
to
c8c547c
Compare
ntruchsess
previously approved these changes
Jul 14, 2023
ntruchsess
force-pushed
the
feature/CPLP-2847-selfDescription
branch
from
c8c547c
to
4ca04a8
Compare
ntruchsess
force-pushed
the
feature/CPLP-2847-selfDescription
branch
from
4ca04a8
to
f15b494
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ntruchsess
previously approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the data structure for the endpoints
/api/administration/connectors/clearinghouse/selfDescription
/api/administration/registration/clearinghouse/selfDescription
have been changed for selfDescriptionDocument from string to JsonDocument
BREAKING CHANGE: data structure for endpoints changed
Why
The external requests are sending the selfDescription document as json, it's easier to take it as it is and don't have the external services convert the json to a string
Issue
N/A - Jira Issue: CPLP-2847
Checklist
Please delete options that are not relevant.