Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registration): add process to decline own companies registration #746

Conversation

ntruchsess
Copy link
Contributor

@ntruchsess ntruchsess commented May 20, 2024

Description

process-based decline registration for application-id has been implemented

Why

a company that has a open application should be able to decline it's own application instead of submitting it.

Issue

N/A (external ref: CPLP-3548)

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@ntruchsess ntruchsess changed the title Feature/cplp 3548 decline registration feat(registration): add process to decline registration May 20, 2024
@ntruchsess ntruchsess changed the title feat(registration): add process to decline registration feat(registration): add process to decline own companies registration May 20, 2024
@ntruchsess ntruchsess force-pushed the feature/CPLP-3548-decline-registration branch from af2d7d6 to 31343c5 Compare May 20, 2024 21:31
@ntruchsess ntruchsess force-pushed the feature/CPLP-3548-decline-registration branch 3 times, most recently from e42643e to bb4569b Compare May 20, 2024 23:13
@ntruchsess ntruchsess marked this pull request as ready for review May 20, 2024 23:25
@ntruchsess ntruchsess requested a review from Phil91 May 20, 2024 23:25
@ntruchsess ntruchsess force-pushed the feature/CPLP-3548-decline-registration branch 5 times, most recently from f4306b2 to 19a84b2 Compare May 21, 2024 00:12
@jjeroch jjeroch added the priority PR needs to prioritized at review label May 21, 2024
@jjeroch jjeroch added this to the Release 24.05 milestone May 21, 2024
@ntruchsess ntruchsess force-pushed the feature/CPLP-3548-decline-registration branch from 19a84b2 to e1d4380 Compare May 21, 2024 17:05
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess deleted the branch eclipse-tractusx:release/v2.0.0-RC9 May 22, 2024 17:27
@ntruchsess ntruchsess closed this May 22, 2024
@ntruchsess
Copy link
Contributor Author

ntruchsess commented May 22, 2024

recreated as #757 after automatic closure due to merge of target-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants