fix(role assignment): fix query for core offer role assignment #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jjeroch
approved these changes
May 21, 2024
evegufy
approved these changes
May 21, 2024
ntruchsess
merged commit d7fd0cc
into
eclipse-tractusx:release/v2.0.0-RC9
13 checks passed
ntruchsess
added a commit
that referenced
this pull request
May 22, 2024
* feat(document): enhance companyDetailsWithAddress endpoint (#732) * add documents section to endpoint companydetailaddress * remove documents section from applications endpoint * adjust unit tests --------- Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de> * fix(decline): add decline url for invite process (#727) Refs: #701 * feat(app): add roleId for exitisting activeRoleDetails (#744) Ref : #705 * fix(seeding-data): add self description document for Catena-X (#707) Reviewed-By: Phil Schneider <info@philschneider.de> Refs: #702 * fix(dim) don't create keycloak sa for dim (#745) * fix(role-management): fix query selecting role-data for core-offer role assignement (#749) * feat(services): update permission for api endpoints added (#751) * fix(keycloak): set clockSkew to 5 min (#753) * chore: fix file header #752 * fix(offersubscription): fix queries throwing a system exception instead of returning default value (#755) * fix 'System.InvalidOperationException: Nullable object must have a value' caused by queries selecting a (non-nullable) guid from a joined table where the joined table does not have a matching dataset resulting in 'null' being returned from the database. * build(2.0.0-rc9): bump version and update docs --------- Co-authored-by: AnuragNagpure <145100366+AnuragNagpure@users.noreply.github.com> Co-authored-by: Phil Schneider <info@philschneider.de> Co-authored-by: VPrasannaK94 <117351802+VPrasannaK94@users.noreply.github.com> Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query being used to determine roles to be assigned has been adjusted to not include unassigned but not requested and assignable roles.
Why
update of core-offer-roles would result in all roles to be assigned that are assignable in respect to the assigned company-roles
Issue
#748
Checklist
Please delete options that are not relevant.