Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin credential): add revoke feature #807

Conversation

nidhigarg-bmw
Copy link
Contributor

Description

  • Implement Credential Revocation Feature for Issuer Admin Board
  • Add Credential Status to Credential Admin Board

Why

Implement a revocation feature that allows issuers with the "revoke_credentials_issuer" permission to revoke credentials marked as "Active."

Issue

#768
#774

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@nidhigarg-bmw nidhigarg-bmw requested review from evegufy, oyo, lavanya-bmw and manojava-gk and removed request for evegufy May 17, 2024 10:58
@jjeroch jjeroch added the priority PR needs to prioritized at review label May 19, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nidhigarg-bmw nidhigarg-bmw marked this pull request as draft May 21, 2024 10:36
@nidhigarg-bmw nidhigarg-bmw marked this pull request as ready for review May 21, 2024 12:58
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy evegufy merged commit edd7065 into eclipse-tractusx:release/v2.0.0-RC8 May 22, 2024
8 checks passed
@evegufy evegufy deleted the feat/768/AdminBoardRevokeFeat branch May 22, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants