Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new values for bpdm pool and company urls #317

Merged

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented May 15, 2024

Description

add new values for bpdm pool and company urls.
remove existing value from chart

related change in the portal frontend: eclipse-tractusx/portal-frontend#731

Why

eclipse-tractusx/portal-frontend#623

Checklist

  • I have performed a self-review of my changes

@manojava-gk manojava-gk requested a review from evegufy May 15, 2024 10:36
@manojava-gk manojava-gk marked this pull request as ready for review May 15, 2024 10:36
@manojava-gk manojava-gk requested a review from oyo May 15, 2024 10:36
@manojava-gk
Copy link
Contributor Author

@evegufy any comments on this?

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to merged at the same time as eclipse-tractusx/portal-frontend#731, otherwise the config is out of sync on the dev env

@evegufy evegufy merged commit 90b85ed into eclipse-tractusx:dev Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants