Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updating Arc42 document #100

Closed
wants to merge 12 commits into from
Closed

docs: Updating Arc42 document #100

wants to merge 12 commits into from

Conversation

adkumar1
Copy link
Contributor

SebastianBezold
SebastianBezold requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adkumar1,

besides my comment on the Notice section for our docs. Please clean up this PR. You state, that it is fixing a single issue (which it should), but you include a whole bunch of other stuff. Plaese create isolated PRs with fixes instead of bundling everything together

docs/ARC42.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adkumar1, please read TRG 7.07 carefully.
You do need to state licence info in your documentation. But as Notice section, that can be read by someone reading your docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharathshivprasad : Please have a look

@evegufy evegufy mentioned this pull request Feb 22, 2024
Closed
@adkumar1
Copy link
Contributor Author

adkumar1 commented Feb 22, 2024 •
edited

Hi @adkumar1,

besides my comment on the Notice section for our docs. Please clean up this PR. You state, that it is fixing a single issue (which it should), but you include a whole bunch of other stuff. Plaese create isolated PRs with fixes instead of bundling everything together

Will do that. But It was done to avoid conflict in CHANGELOG.md file

@adkumar1
Copy link
Contributor Author

Closing this PR as updated separately in PR #102

@adkumar1 adkumar1 closed this Feb 22, 2024
@adkumar1 adkumar1 deleted the arc42 branch March 7, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianBezold SebastianBezold SebastianBezold requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TRG 7.07: Remove file header from md file and add NOTICE as post or preamble instead
2 participants
@adkumar1 @SebastianBezold