Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring expression addition #33

Merged
merged 3 commits into from Apr 21, 2023
Merged

Spring expression addition #33

merged 3 commits into from Apr 21, 2023

Conversation

adkumar1
Copy link
Contributor

No description provided.

dvasunin
dvasunin approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@dvasunin dvasunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a library upgrade

Siegfriedk
Siegfriedk requested changes Apr 19, 2023
View reviewed changes
DEPENDENCIES Outdated
@@ -190,6 +190,7 @@ maven/mavencentral/org.springframework/spring-beans/6.0.7, Apache-2.0, approved,
maven/mavencentral/org.springframework/spring-context/6.0.7, Apache-2.0, approved, #5936
maven/mavencentral/org.springframework/spring-core/6.0.7, Apache-2.0 AND BSD-3-Clause, approved, #5948
maven/mavencentral/org.springframework/spring-expression/6.0.7, Apache-2.0, approved, #3284
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can this be? Do you now really have both versions in your repo or did you not run the dash tool properly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an error with running the tool, you are correct, we only use new version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adkumar1 @dvasunin @Wulghash make sure to never do this manually somehow! ever again!

@Siegfriedk Siegfriedk merged commit 55803a1 into eclipse-tractusx:main Apr 21, 2023
3 checks passed
@Siegfriedk Siegfriedk deleted the spring-expression-6.0.8 branch April 21, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wulghash Wulghash Wulghash left review comments

@Siegfriedk Siegfriedk Siegfriedk requested changes

@dvasunin dvasunin dvasunin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adkumar1 @dvasunin @Wulghash @Siegfriedk @fedornaz