How to deal with minimal model updates #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bs-jokri
requested changes
May 15, 2023
|
Thanks for the comments. Models don't really have an "API", they are the foundation for generation of an API. I've added a reference but and wrote more precise criteria for what change consitutes what increment |
|
From discussion: legal requirements are probably no minor change but major, eg change of copyright header |
|
Removing or adding optional elements is not a minor change as it implies a breaking change -> important add for item "minor changes" that backward compatibility needs to be maintained |
|
@arnoweiss have you had a chance to adjust according to our previous discussion? |
bs-jokri
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR amends the governance process with regard to how semantic versioning shall be interpreted in the scope of this project.
Closes #130