This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
docs: add test case details and sample data for verifier tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @jimmarino |
maximilianschmidt-zf
suggested changes
Jul 20, 2023
docs/testkit/sample_input/v-t_0003.a_vc_embedded_forged_claim.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0003.b_vc_embedded_altered_credentialsubject.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0003.c_vc_embedded_altered_claim.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0004.a_vc_embedded_forged_proof.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0004.b_vc_embedded_invalid_proof.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0002_valid_vc_embedded_proof.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Schmidt (ZF Friedrichshafen AG) <104348964+maximilianschmidt-zf@users.noreply.github.com>
jimmarino
reviewed
Aug 2, 2023
| "credentialSubject": { | ||
| "http://schema.org/identifier": "BPNL000000000000", | ||
| "id": "did:web:localhost:BPNL000000000000", | ||
| "type": "https://org.eclipse.tractusx/businessPartnerData#BpnCredential" |
There was a problem hiding this comment.
Have these types changed to C-X? @wolf4ood
There was a problem hiding this comment.
this is not specific to a Catena-X or any other VC, so if anything, we should remove those references.
maximilianschmidt-zf
suggested changes
Aug 2, 2023
docs/testkit/sample_input/v-t_0002_valid_vc_embedded_proof.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0003.a_vc_embedded_forged_claim.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0003.b_vc_embedded_altered_credentialsubject.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0003.c_vc_embedded_altered_claim.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0004.a_vc_embedded_forged_proof.json
Outdated
Show resolved
Hide resolved
docs/testkit/sample_input/v-t_0004.b_vc_embedded_invalid_proof.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Schmidt (ZF Friedrichshafen AG) <104348964+maximilianschmidt-zf@users.noreply.github.com>
yep correct. i just copy-pasted it... |
|
merging, as all comments have been addressed, and re-reviews are open for multiple days |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
adds test specification and some sample test data for verifier tests. Issuer tests will follow in another PR, as well as more test data/.
WHY
to have a specified test set for verifier tests