Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add transform-and-upload.py to publish assets #3

Conversation

ds-lcapellino
Copy link
Contributor

@ds-lcapellino ds-lcapellino commented Mar 12, 2024

Description

  • add python script to publish assets
  • add corresponding documentation how to use the script

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ds-lcapellino,

nice that there is some progress on this topic 👍
Not really familiar with python, so I cannot give any feedback on that.
With my knowledge, it seems like only built in libraries are used, so no 3rd party IP checks needed, right?

scripts/transform-and-upload.py Show resolved Hide resolved
@SebastianBezold
Copy link
Contributor

Hey @ds-lcapellino,

to document for everyone else: You mentioned, that only the requests lib is not part of the Python core. I found an IPlab issue, that is already approved, for the exact version 2.31.0 you are using. So this is fine for me.
Since we do not have an automated way to create a DEPENDENCIES file via dash, I'll add the repsective info to the NOTICE.md after merging this PR.

Could you please double check, if I missed something?

@ds-lcapellino
Copy link
Contributor Author

ds-lcapellino commented Mar 13, 2024

Hey @SebastianBezold,
I rechecked and there are only standard modules from Python used besides requests:2.31.0.
I will wait for an Eclipse Committer with good Python skills to review the Python file.

@SebastianBezold
Copy link
Contributor

Since no one could do a review on the python script yet, I'll take it as is and add the dependency annotations to NOTICE.md right after merging this PR

@SebastianBezold SebastianBezold merged commit d933ec9 into eclipse-tractusx:main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants