feat: reactivate natural sorting order of notification by severity #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s by severity [Summary]: This commit reverts the sorting order of notifications (alerts and investigations) to follow a natural sorting order based on severity. Previously, the sorting method was sorted alphabetically [Changes Made]: - Modified/Added the SQL query responsible for sorting notifications by severity. - Utilized a formula for natural sorting order based on severity. [Context/Reasoning]: Natural sorting by severity provides a more intuitive and user-friendly display of notifications, ensuring that higher severity issues are prioritized appropriately.
| "WHEN A.severity = 'CRITICAL' THEN 2 " + | ||
| "WHEN A.severity = 'LIFE_THREATENING' THEN 3 " + | ||
| "ELSE -1 END FROM alert_notification A WHERE A.alert_id = id LIMIT 1)") | ||
| private Integer severityRank; |
There was a problem hiding this comment.
I think its kind of confusing adding this logic as sql. It would be cleaner to add the rank of the natural order to the QualityNotificationSeverity Enum and sort its value
| @@ -74,7 +74,7 @@ private static Sort toDomainSort(final List<String> sorts, BaseRequestFieldMappe | |||
| try { | |||
| String[] sortParams = sort.split(","); | |||
| orders.add(new Sort.Order(Sort.Direction.valueOf(sortParams[1].toUpperCase()), | |||
| fieldMapper.mapRequestFieldName(sortParams[0]))); | |||
| handleEnumColumns(fieldMapper.mapRequestFieldName(sortParams[0])))); | |||
There was a problem hiding this comment.
Please add the new supported field to QualityNotificationFieldMapper and remove the newly created method.
ds-lcapellino
suggested changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature: reactivate natural sorting order of notifications by severity
[Issue]:
[Summary]:
[Changes Made]:
[Context/Reasoning]: