Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDR API: contractNegotiationId #836

Closed
wolf4ood opened this issue Oct 19, 2023 · 1 comment · Fixed by #847
Closed

EDR API: contractNegotiationId #836

wolf4ood opened this issue Oct 19, 2023 · 1 comment · Fixed by #847
Assignees
@wolf4ood
Labels
enhancement New feature or request

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Oct 19, 2023 •
edited

WHAT

Since the post to /edrs api for starting a new EDR negotiation returns the id of the contract negotiation process,
it make sense for consumer to be able to filter EDRs also for this id.

  • We have to store the negotiation id in the EndpointDataReferenceEntry
  • Support an additional parameters for filtering EDRs by contractNegotiationId
@wolf4ood wolf4ood added enhancement New feature or request triage all new issues awaiting classification labels Oct 19, 2023
@wolf4ood wolf4ood changed the title EDR API EDR API: contractNegotiationId Oct 19, 2023
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Oct 19, 2023
@wolf4ood wolf4ood self-assigned this Oct 19, 2023
@wolf4ood wolf4ood mentioned this issue Oct 24, 2023
Merged
@matgnt
Copy link

matgnt commented Oct 25, 2023

Thank you @wolf4ood for the quick implementation!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
enhancement New feature or request
Projects
EDC Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Edr API): associates contractNegotiationId EdrEntry wolf4ood/tractusx-edc
2 participants
@wolf4ood @matgnt