Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Edr API): associates contractNegotiationId EdrEntry #847

Merged
merged 3 commits into from Oct 25, 2023
Merged

feat(Edr API): associates contractNegotiationId EdrEntry #847

merged 3 commits into from Oct 25, 2023

Conversation

wolf4ood
Copy link
Contributor

WHAT

Adds contractNegotiationId as additional field in EpointDataReferenceEntry.

Changes:

  • Supported the new field in the EDR InMemory Impl
  • Supported the new field in the Sql Impl
  • Add the additional filter in the edrs endpoint of querying EDRs

WHY

enabling correlation between POST|/edrs and GET|/erds

Closes #836

@wolf4ood wolf4ood marked this pull request as ready for review October 24, 2023 15:01
@wolf4ood
Copy link
Contributor Author

cc/ @matgnt

tuncaytunc-zf
tuncaytunc-zf approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@tuncaytunc-zf tuncaytunc-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wolf4ood wolf4ood merged commit d4a69a2 into eclipse-tractusx:main Oct 25, 2023
25 checks passed
@wolf4ood wolf4ood deleted the feat/836_cn_id branch October 25, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@tuncaytunc-zf tuncaytunc-zf tuncaytunc-zf approved these changes

@ndr-brt ndr-brt Awaiting requested review from ndr-brt

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDR API: contractNegotiationId
3 participants
@wolf4ood @paullatzelsperger @tuncaytunc-zf