Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move all dataplane proxy code to edc-extensions #505

Merged
merged 1 commit into from
Jun 20, 2023
Merged

refactor: move all dataplane proxy code to edc-extensions #505

merged 1 commit into from
Jun 20, 2023
+12 −12

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jun 19, 2023 •
edited
Loading

WHAT

Moves all edc-dataplane-proxy-* modules to edc-extensions/dataplane-proxy.

WHY

the edc-dataplane directory should only contain launcher modules and docker files.

FURTHER NOTES

  • this is just a refactoring PR, no code changes were made.
  • I left the original module names intact, but we could potentially shorten them a bit, e.g. edc-dataplane-proxy-provider-spi could become dpp-provider-spi or even just provider-api

Closes # <-- insert Issue number if one exists

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

jimmarino
jimmarino approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the "edc" prefix entirely and organize the module structure similar to how it is in EDC? In a separate PR, of course.

@paullatzelsperger paullatzelsperger merged commit 5c2e33d into eclipse-tractusx:main Jun 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

@jimmarino jimmarino jimmarino approved these changes

@tuncaytunc-zf tuncaytunc-zf tuncaytunc-zf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paullatzelsperger @wolf4ood @jimmarino @tuncaytunc-zf