Skip to content

Commit

Permalink
Remove warning about unspecified environment
Browse files Browse the repository at this point in the history
Currently if not target platform environment is specified Tycho emits a
warning "No explicit target runtime environment configuration. Build is
platform dependent." beside from that nothing ever seems go wrong and
actually Tycho builds *can* be environment agnostic. Also there is not
really a way to tell Tycho that it is okay, so either the user has to
use a specific one or configure many ones that make resolving slower.

This now removes this warning, if with modern Tycho there are any
problems that arise from a missing environment configuration one should
better give a specific error/hint at this place instead of warn "just in
case".

(cherry picked from commit 8395720)
  • Loading branch information
laeubi committed Jan 20, 2024
1 parent b9c6f9f commit 9cd0883
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,6 @@ public TargetPlatformConfiguration getTargetPlatformConfiguration(MavenSession s
}

if (result.getEnvironments().isEmpty()) {
// applying defaults
logger.warn("No explicit target runtime environment configuration. Build is platform dependent.");
result.addEnvironment(TargetEnvironment.getRunningEnvironment());
result.setImplicitTargetEnvironment(true);
} else {
Expand Down

0 comments on commit 9cd0883

Please sign in to comment.