Skip to content

Commit

Permalink
Reduce printed warnings in builds
Browse files Browse the repository at this point in the history
There are a lot of "[WARNING] Using JavaSE-21 to fulfill requested
profile of JavaSE-17. This might lead to faulty dependency resolution,
consider defining a suitable JDK in the toolchains.xml." in builds if no
toolchain.xml  is defined. But with modular JVMs even having same EE
version doesn't guarantee same APIs are available in the JVM thus
reducing severity of the message to debug so it can still be printed for
the rare cases when that might be useful.

(cherry picked from commit 969abc4)
  • Loading branch information
akurtakov authored and eclipse-tycho-bot committed Feb 27, 2024
1 parent d46c374 commit f02cbbb
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2008, 2022 Sonatype Inc. and others.
* Copyright (c) 2008, 2024 Sonatype Inc. and others.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
Expand Down Expand Up @@ -34,8 +34,8 @@
import org.eclipse.equinox.p2.metadata.IInstallableUnit;
import org.eclipse.osgi.internal.framework.EquinoxConfiguration;
import org.eclipse.tycho.ExecutionEnvironment;
import org.eclipse.tycho.TargetEnvironment;
import org.eclipse.tycho.ExecutionEnvironment.SystemPackageEntry;
import org.eclipse.tycho.TargetEnvironment;
import org.eclipse.tycho.core.ee.StandardExecutionEnvironment.JavaInfo;
import org.osgi.framework.BundleActivator;
import org.osgi.framework.Constants;
Expand Down Expand Up @@ -67,11 +67,11 @@ private static Properties readProperties(final URL url) {
* Get the execution environment for the specified OSGi profile name.
*
* @param profileName
* profile name value as specified for key "Bundle-RequiredExecutionEnvironment" in
* MANIFEST.MF
* profile name value as specified for key
* "Bundle-RequiredExecutionEnvironment" in MANIFEST.MF
* @return the corresponding {@link ExecutionEnvironment}.
* @throws UnknownEnvironmentException
* if profileName is unknown.
* if profileName is unknown.
*/
public static StandardExecutionEnvironment getExecutionEnvironment(String profileName, ToolchainManager manager,
MavenSession session, Logger logger) throws UnknownEnvironmentException {
Expand All @@ -90,7 +90,7 @@ public static StandardExecutionEnvironment getExecutionEnvironment(String profil
return split[0] + "-" + v;
}).map(map::get).filter(Objects::nonNull).findFirst().orElse(null);
if (higherEE != null) {
logger.warn("Using " + higherEE.getProfileName() + " to fulfill requested profile of " + profileName
logger.debug("Using " + higherEE.getProfileName() + " to fulfill requested profile of " + profileName
+ ". This might lead to faulty dependency resolution, consider defining a suitable JDK in the toolchains.xml.");
return getSurrogate(profileName, higherEE);
}
Expand Down

0 comments on commit f02cbbb

Please sign in to comment.