PRs with pending reviews are merged #3661
Comments
|
@netomi do you have any hints for us? Actually the ip check should be a required check for the branch protection: |
|
Looking at the latest data I can see that all checks for the PR passed:
The number of required approvals is set to 0, but I guess dependabot is configured to auto-merge if all checks pass. Maybe you wanna disable that. |
|
The automerge is actually desired. I now found the offending commit here: https://github.com/eclipse-tycho/tycho/actions/runs/8243909268/job/22562813997 it says that the check passed, but the logfile indicates differently @HannesWell could it be that the request for a license (what now works automatically 👍 ) makes the result of the check "green"? |
|
ah indeed I did not check the license checking workflow. It indeed output some error but does not propagate whether the job failed or not. I suggest to add a final step to the workflow to return 0 if all licenses are vetted or something else if not to be able to use it with branch protection rules and dependabot. |
I have to look it up again since the change of license work-flow to allow auto-request of dependa-bot PR is already some time in the past. |
|
I just noticed that the comment seems to be added automatically there also for example: maybe because github action is now a valid ECA user? |
IIRC the problem that the automated requests of license reviews for dependabot PRs was on the GitHub side since the dependabot user didn't have access to repo/organisation secrets and therefore could not obtain the EF-Gitlab-token. Nevertheless, I looked through the workflow and indeed the workflow falsely didn't fail in case of automatically created vetting-requests. |
Since eclipse#220 license-reviews are automatically requested for PRs created by dependabot. But in that change the logic of the 'Process license check results' step was not updated to consider that case. This had the effect that the license-vetting workflow always succeeded for PRs created by dependabot. The intention to not fail the workflow in general when a license-review was requested is because initially review-request were only created manually from committers by adding a corresponding comment to the PR. And that workflow execution should not fail respectively its result was actually irrelevant. Fixes eclipse-tycho/tycho#3661
Since eclipse#220 license-reviews are automatically requested for PRs created by dependabot. But in that change the logic of the 'Process license check results' step was not updated to consider that case. This had the effect that the license-vetting workflow always succeeded for PRs created by dependabot. The intention to not fail the workflow in general when a license-review was requested is because initially review-request were only created manually from committers by adding a corresponding comment to the PR. And that workflow execution should not fail respectively its result was actually irrelevant. Fixes eclipse-tycho/tycho#3661
Since #220 license-reviews are automatically requested for PRs created by dependabot. But in that change the logic of the 'Process license check results' step was not updated to consider that case. This had the effect that the license-vetting workflow always succeeded for PRs created by dependabot. The intention to not fail the workflow in general when a license-review was requested is because initially review-request were only created manually from committers by adding a corresponding comment to the PR. And that workflow execution should not fail respectively its result was actually irrelevant. Fixes eclipse-tycho/tycho#3661
All testing was successful and the PR is submitted. This issue should now be fixed. |
|
Thank you! This will further simplify things when upgrading! |
E.g. #3638 is merged despite licensecheck complaining as it finds out https://github.com/eclipse-tycho/tycho/actions/runs/8253529633/job/22575590947 there is iplab issue is open.
The text was updated successfully, but these errors were encountered: