Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generify PomDependencyCollector #1117

Closed
wants to merge 1 commit into from

Conversation

akurtakov
Copy link
Member

No description provided.

@laeubi
Copy link
Member

laeubi commented Jul 8, 2022

@akurtakov sadly this will not (yet) work as the IInstallableUnit in the "Maven World" is not compatible with the one in "OSGi World", so don't be confused.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b7f1e0b.

@akurtakov
Copy link
Member Author

Closing. It would be good if you can give some extra details what's going on here.

@akurtakov akurtakov closed this Jul 8, 2022
@laeubi
Copy link
Member

laeubi commented Jul 8, 2022

Tycho starts an OSGi Framework (that is the tycho-bundle-product) for the P2 parts and calls into this framework with this "shared" classes (what we export as system-packages), sadly we can currently not share the P2 classes itself, that's why "untyped" Collections are used here. It would be good if we can export the P2 API as well, but because P2 uses API+Impl in one bundle and heavily relies on require bundle this is not easy. Thus I already started to refactor P2 but that's quite hard as well (to not 'break' existing code).

Beside that, I have started to implement some of this functionality in "pure java" that could be used in the maven world as well, but currently these object can't 'cross the border'. This works quite well when it comes to the resolver itself, but the repository part its quite complex as it mangles a lot of concepts (extension points, OSGI service and Agent service).

So I hope that once there will be a point where we "meet in the middle" and can either join both worlds or even get rid of the embedded OSGi-Framework and then we can not only use generics here but throw away a lot of stuff that currently converts back-and-forth.

If you like to dig into this, you can try to export some packages of P2 into the OSGi world and look whats missing and how far we can get...

@laeubi
Copy link
Member

laeubi commented Jul 12, 2022

@akurtakov FYI related P2 issue: eclipse-equinox/p2#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants