SharedHttpCacheStorage doesnt resolve redirect correctly if the uri that is given isn't normalized #2666 #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
requested changes
Jul 28, 2023
p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/transport/SharedHttpCacheStorage.java
Outdated
Show resolved
Hide resolved
jcompagner
force-pushed
the
normalize_url
branch
from
c54915f
to
07776d0
Compare
that is given isn't normalized eclipse-tycho#2666 make sure taht the incoming uri param is normalized when used further up. This way it is not an extra redirect (so there are 2 redirects to the final source)
jcompagner
force-pushed
the
normalize_url
branch
from
07776d0
to
fe75433
Compare
laeubi
added
the
backport-to-tycho-4.0.x
|
@jcompagner sadly Github seem to be confused now: "This branch cannot be rebased due to too many changes", do you think you can create a new branch from master (maybe so we need to wait until github issue is resolved see |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for SharedHttpCacheStorage doesnt resolve redirect correctly if the uri that is given isn't normalized #2666
make sure taht the incoming uri param is normalized when used further
up. This way it is not an extra redirect (so there are 2 redirects to
the final source)