Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the last modified timestamp is set correctly #2714

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Aug 19, 2023

Linux stores modification time with nano-seconds precision, but we currently set the timestamp of the cached file only in milliseconds. This can lead to the situation that the source is considered a few nanoseconds older than the cache file and therefore the cache is regenerated every time.

@laeubi laeubi requested a review from HannesWell August 19, 2023 17:21
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Aug 19, 2023
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Aug 19, 2023

Test Results

   561 files  ±0     561 suites  ±0   4h 35m 43s ⏱️ + 16m 10s
   361 tests ±0     355 ✔️ ±0    6 💤 ±0  0 ±0 
1 083 runs  ±0  1 064 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 4673cc2. ± Comparison against base commit 2fcedec.

♻️ This comment has been updated with latest results.

Linux stores modification time with nano-seconds precision, but we
currently set the timestamp of the cached file only in milliseconds.
This can lead to the situation that the source is considered a few
nanoseconds older than the cache file and therefore the cache is
regenerated every time.
@laeubi laeubi merged commit 57f0ce6 into eclipse-tycho:master Aug 20, 2023
10 checks passed
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants