Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to filter repo-references before being added to a p2-repo #2753

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

HannesWell
Copy link
Member

Back-port of #2742 for Tycho 4.0.x

Add a new parameter named 'repositoryReferenceFilter' to the
AssembleRepositoryMojo to better control the automatic addition of
repository references with matching locations.
This can be used with ANT-style or Java RegEx patterns as follows:

<repositoryReferenceFilter>
	<exclude>
		<location>https://foo.bar.org/hidden/**</location>
		<location>https://foo.bar.org/secret/**</location>
	</exclude>
	<include>%regex[http(s)?:\/\/foo\.bar\.org\/.*]</include>
</repositoryReferenceFilter>

The is especially convenient in combination with the automatic addition
of IU Target-Repository or POM-Repository references, if some but not
all repos should be added.
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

   561 files     561 suites   4h 44m 28s ⏱️
   362 tests    356 ✔️   6 💤 0
1 086 runs  1 067 ✔️ 19 💤 0

Results for commit 8e2f074.

@HannesWell HannesWell merged commit a586e22 into eclipse-tycho:tycho-4.0.x Sep 5, 2023
8 checks passed
@HannesWell HannesWell deleted the backport2742 branch September 5, 2023 22:18
@@ -2,6 +2,29 @@

This page describes the noteworthy improvements provided by each release of Eclipse Tycho.

## 4.0.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case it is sufficient for a backport to only have a short summary of what was done but the "long form" is fine as well)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about that point because actually this feature is then not new in 5 because it will be first introduced in 4.0.3.
But since they are on different branches it will not appear on master with 4.0.3.
Nevertheless it could be confusing if one has used a feature and now reads that it is new in a later version.
Do you plan to 'forward' port the Release notes on a 4.0.3 or at least 5 release to the master?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I copy them after the realese from the release branch to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants