Backport: Follow P2 contract of cached file's extension (#2938) #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
approved these changes
Oct 21, 2023
laeubi
added
the
backport-to-tycho-4.0.x
Test Results 567 files + 3 567 suites +3 4h 31m 51s ⏱️ - 28m 0s For more details on these errors, see this check. Results for commit d544578. ± Comparison against base commit 486e6e4. ♻️ This comment has been updated with latest results. |
|
@basilevs can you please target the |
basilevs
changed the title
laeubi
removed
the
backport-to-tycho-4.0.x
|
@basilevs build seems fine now, can you rebase and squash your commits? |
This is a backport from 5.0.0 P2 relies on correct file extensions to parse cached files. This change prevents cached file name from changing over HTTP redirect. See eclipse-equinox/p2#355 Fix HttpServer concurrency bug. URLs returned from HttpServer.getAccessedUrls() are now stripped of context prefix. No callers have used these values until now. Fix concurrency bug in test utility class HttpServer request logging. Add verification of request logs to ensure that metadata repository does indeed unjars fresh, non-cached artifact. Ensure that cached XML file does not produce false negative in tests. Refactor tests.
basilevs
force-pushed
the
issue_2938_reproducer
branch
from
d4d443d
to
d544578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2938
This is a backport of #2945
CacheManagerinjected from Tycho into P2 names cached downloads internally based on their URLsThis change ensures that CacheManager injected into P2 adheres to the contract and returns cached files with extensions matching the (original, before redirect) request.
eclipse-equinox/p2#355 discusses fix on P2 side.