Add a reproducer IT for issue #2977

[mdaloia]

Virtual configuration IU in p2.inf does not work in 4.0.3 (works in 3.0.5)

If we add this statement in the VirtualUnitTest:

verifier.addCliOption("-Dtycho-version=3.0.5");

the test works ok and does not fail.

[laeubi]

@mdaloia thanks for your testcase, I assume these is the expected failure:
https://ci.eclipse.org/tycho/job/tycho-github/job/PR-2978/1/testReport/junit/org.eclipse.tycho.test.p2Inf/VirtualUnitTest/testVirtualUnitRequirementDoesNotFailBuild/

[mdaloia]

@laeubi yes, the error, as mentioned in the issue #2977 is:

[ERROR] Cannot resolve project dependencies:
[ERROR]   Software being installed: pvu.bundle 1.0.0.qualifier
[ERROR]   Missing requirement: pvu.bundle 1.0.0.qualifier requires 'org.eclipse.equinox.p2.iu; configure.pvu.bundle 0.0.0' but it could not be found

I added it as a regression test, I expected it to fail. Let me know if that it is ok or should I modify it somehow.

Thanks!

[laeubi]

I'll try to investigate why this fails.

[laeubi]

I have now checked this and it seems the p2content.xml in both cases is the same (except the build qualifier) for Tycho 4 and Tycho 3 so it seems not be a problem of generated metadata, but probably somewhere the provided capability is lost.

[laeubi]

I now have created

• Print registered extensions in framework debug #2988

for further debugging, but this also seems sane, need to investigate further...

[laeubi]

The preliminary units look like this what seems to be sane as well:

<?xml version='1.0' encoding='UTF-8'?>
<units size='2'>
  <unit id='configure.pvu.bundle' version='1.0.0' singleton='false'>
    <provides size='1'>
      <provided namespace='org.eclipse.equinox.p2.iu' name='configure.pvu.bundle' version='1.0.0'/>
    </provides>
    <touchpoint id='null' version='0.0.0'/>
  </unit>
  <unit id='pvu.bundle' version='1.0.0.qualifier' generation='2'>
    <update id='pvu.bundle' range='[0.0.0,1.0.0.qualifier)' severity='0'/>
    <properties size='2'>
      <property name='org.eclipse.equinox.p2.name' value='pvu.bundle'/>
      <property name='org.eclipse.equinox.p2.provider' value='TEST'/>
    </properties>
    <provides size='4'>
      <provided namespace='org.eclipse.equinox.p2.iu' name='pvu.bundle' version='1.0.0.qualifier'/>
      <provided namespace='osgi.bundle' name='pvu.bundle' version='1.0.0.qualifier'/>
      <provided namespace='osgi.identity' name='pvu.bundle' version='1.0.0.qualifier'>
        <properties size='1'>
          <property name='type' value='osgi.bundle'/>
        </properties>
      </provided>
      <provided namespace='org.eclipse.equinox.p2.eclipse.type' name='bundle' version='1.0.0'/>
    </provides>
    <requires size='2'>
      <requiredProperties namespace='osgi.ee' match='(&amp;(osgi.ee=JavaSE)(version=17))'>
        <description>
          pvu.bundle
        </description>
      </requiredProperties>
      <required namespace='org.eclipse.equinox.p2.iu' name='configure.pvu.bundle' range='0.0.0'/>
    </requires>
    <artifacts size='1'>
      <artifact classifier='osgi.bundle' id='pvu.bundle' version='1.0.0.qualifier'/>
    </artifacts>
    <touchpoint id='org.eclipse.equinox.p2.osgi' version='1.0.0'/>
    <touchpointData size='1'>
      <instructions size='2'>
        <instruction key='zipped'>
          true
        </instruction>
        <instruction key='manifest'>
          Bundle-SymbolicName: pvu.bundle;singleton:=true&#xA;Bundle-Version: 1.0.0.qualifier&#xA;
        </instruction>
      </instructions>
    </touchpointData>
  </unit>
</units>

[laeubi]

Looking at the project resolved target platform it contains the bundle itself (with the additional requirement) but not the units from p2.inf so the advice get applied, but the additional units seem to be lost.

[laeubi]

@mdaloia thanks for the testcase I have now added this and a fix to this PR:

• Pr 2978 #2989

[laeubi]

Backport is now here:

• Backport p2inf #2991

so we can close this now!