Remove equinox-launcher fragments handling in AbstractArtifactDependencyWalker #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractArtifactDependencyWalker The AbstractArtifactDependencyWalker is only used to determine the build-qualifier of of features, products and repositories and for that should only consider what's contained in those assembly-artifacts. It therefore should not add any special fragments to the set of considered artifacts. This also helps to simplify the situation for equinox-launcher fragments for Mac, where still a special treatment for CARBON API artifacts exists, although the org.eclipse.equinox.launcher.carbon.macosx artifact is not supported anymore since 2012 [1]. Required for eclipse-equinox/equinox#622 [1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400
HannesWell
added
the
backport-to-tycho-4.0.x
laeubi
approved these changes
May 20, 2024
Test Results 594 files ±0 594 suites ±0 4h 6m 8s ⏱️ - 5m 19s For more details on these failures and errors, see this check. Results for commit 3e3c38e. ± Comparison against base commit b36b02b. |
|
Test failures are the same as on main and unrelated. |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AbstractArtifactDependencyWalker is only used to determine the build-qualifier of of features, products and repositories and for that should only consider what's contained in those assembly-artifacts. It therefore should not add any special fragments to the set of considered artifacts.
This also helps to simplify the situation for equinox-launcher fragments for Mac, where still a special treatment for CARBON API artifacts exists, although the org.eclipse.equinox.launcher.carbon.macosx artifact is not supported anymore since 2012 [1].
Required for eclipse-equinox/equinox#622
[1] - https://download.eclipse.org/eclipse/updates/4.2/R-4.2-201206081400