Use --release instead of --source/target combo #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
added
the
backport-to-tycho-4.0.x
Test Results 597 files 597 suites 3h 52m 31s ⏱️ Results for commit 1d1049e. ♻️ This comment has been updated with latest results. |
akurtakov
force-pushed
the
main
branch
3 times, most recently
from
def9cbb
to
e1ed79d
Compare
This fixes warnings during build like:
```
[WARNING] location of system modules is not set in conjunction with
-source 17
not setting the location of system modules may lead to class files
that cannot run on JDK 17
--release 17 is recommended instead of -source 17 -target 17 because
it sets the location of system modules automatically
```
and also ensures usage of newer API doesn't slip in.
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings during build like:
and also ensures usage of newer API doesn't slip in.