Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55 - discard packaging of test-fragment #67

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Apr 14, 2021

Signed-off-by: Christoph Läubrich laeubi@laeubi-soft.de

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@akurtakov
Copy link
Member

What is the reason behind this? There are projects (like Platform, CDT, Linux Tools) that use test fragments and publish them to p2 repository so they can be installed later in a provisioned IDE and executed on different OS/WS/ARCH combo without rebuilding everything.

@mickaelistria
Copy link
Contributor

I also don't get why removing this now. Please add explanation in the commit message.

@laeubi
Copy link
Member Author

laeubi commented Apr 14, 2021

This was recently added by me to package classes in target/test-classes (what was previously empty) and generates some kind of generic Manifest, but I found that my initial idea was not ideal and its original intent becomes a bit obsolete now as PDE refuses to allow something similar in the IDE it does not make sense to go this path further and instead I'd #53 will replace this.

So no worries this does not affect existing use-case.

@mickaelistria
Copy link
Contributor

OK, please just add those explanation to the commit message, also fix related tests and then feel free to merge as soon as CI is green.
Could it be a revert of d9a5824 ?

@laeubi
Copy link
Member Author

laeubi commented Apr 14, 2021

I'll do as soon as the replacement for additional bundles is in place, just wanted to see if I break more than these three test cases :-)

The original commit was 9485693 but I think we could keep the extraction of manifest creation as it makes code more clear so I decided to not revert this completely.

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Member Author

laeubi commented Apr 21, 2021

Two test are failing but recent discussions have show that there is no way to support this, so I'll remove the failing test as they are invalid.

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi laeubi merged commit 67dfb7f into eclipse-tycho:master Apr 21, 2021
@laeubi laeubi added this to the 2.4 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants