Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for id property in uattributes #105

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Add validation for id property in uattributes #105

merged 1 commit into from
Apr 17, 2024

Conversation

neelam-kushwah
Copy link
Contributor

stevenhartley
stevenhartley approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you @neelam-kushwah , full test coverage and code, love it!

@stevenhartley stevenhartley merged commit cc41ca8 into eclipse-uprotocol:main Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhartley stevenhartley stevenhartley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neelam-kushwah @stevenhartley