Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix unspecific error messages during model lifecycle #34

Open
1 task done
BjoernAtBosch opened this issue Sep 1, 2023 · 0 comments
Open
1 task done
Labels
bug Something isn't working enhancement New feature or request

Comments

@BjoernAtBosch
Copy link
Member

Severity

Medium

What release version, tag or commit-hash did you use?

v1.2.1

Current Behavior

If referencing a non-existing vss.json from the AppManifest.json and calling velocitas init -f the model lifecycle has this misleading output:

... > Running post init hook for 'vehicle-model-lifecycle'
Running 'install-deps'... done
Running 'download-vspec'... done
Running 'generate-model'... !
 ›   Error: Program returned exit code: 1

Misleading, because the download-vspec should drop the error and not the generate-model.

Also, there is unspecific message if a non-supported VSS version is used (e.g. VSS version 4.0 at the moment).

Also, if model lifecycle fails during devContainer setup, the failure is not clearly visualize and could be quite easily overseen. This seems especially the case if using GH Code Space.

Steps to Reproduce

  1. Change VSS reference in AppManifest to non-existing file
  2. Run velocitas init -f

Expected Behavior

Error messages should clearly point out what the issue is

Possible Solution

Catch specific error messages here: https://github.com/eclipse-velocitas/devenv-devcontainer-setup/blob/main/vehicle-model-lifecycle/src/download_vspec.py#L75

Additional Information

No response

Code of Conduct

  • I agree to follow this project's "Code of Conduct".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant