Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unit files in devenv #58

Merged

Conversation

lukasmittag
Copy link
Contributor

This adds the ability to support unit files from AppManifest.json and therefore allowing to use VSS 4.0 and vss-tools to generate the vehicle model

@lukasmittag
Copy link
Contributor Author

This needs to be merged as first one eclipse-velocitas/vehicle-model-generator#51

vehicle-model-lifecycle/src/download_vspec.py Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/generate_model.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
doosuu
doosuu previously requested changes Mar 21, 2024
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MP91
MP91 previously requested changes Mar 28, 2024
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model generator version needs to be updated

@lukasmittag
Copy link
Contributor Author

then we need to merge model generator first @MP91?

@lukasmittag
Copy link
Contributor Author

do not merge before new version of model generator is released :) needs to be updated accordingly

manifest.json Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/generate_model.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/test/unit/test_download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/test/unit/test_download_vspec.py Outdated Show resolved Hide resolved
@lukasmittag lukasmittag requested a review from MP91 April 29, 2024 12:18
manifest.json Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
vehicle-model-lifecycle/src/download_vspec.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 dismissed stale reviews from MP91 and doosuu May 3, 2024 14:10

vacation

@dennismeister93 dennismeister93 merged commit 40d9494 into eclipse-velocitas:main May 3, 2024
15 checks passed
@MP91 MP91 deleted the update/vss_4 branch May 13, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants