Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Revise Bandit configuration and skipped rules: skips = B101,B404,B603,B607 #33

Closed
1 task done
kse3hi opened this issue Jul 24, 2023 · 2 comments
Closed
1 task done
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@kse3hi
Copy link
Contributor

kse3hi commented Jul 24, 2023

Severity

High

What release version, tag or commit-hash did you use?

https://github.com/eclipse-velocitas/devenv-runtimes/blob/v2.0.0

Current Behavior

Bandit skips next rules: skips = B101,B404,B603,B607

Steps to Reproduce

  1. Go to https://github.com/eclipse-velocitas/devenv-runtimes/blob/main/setup.cfg
  2. Check section [bandit]

Expected Behavior

Bandit shall not skip rules or rational shall be given.

Possible Solution

E.g. for B101 proper configuration of test sources shall be given and no assertion shall be used in productive code.
B404 can be avoided
B603 - analyze deeply
B607 - use properly

Additional Information

No response

Code of Conduct

  • I agree to follow this project's "Code of Conduct".
@kse3hi kse3hi added bug Something isn't working good first issue Good for newcomers labels Jul 24, 2023
@MP91
Copy link
Contributor

MP91 commented Jan 22, 2024

Bandit is completely removed in #57

@kse3hi please check if this can be closed

@kse3hi
Copy link
Contributor Author

kse3hi commented Jan 23, 2024

LGTM

@kse3hi kse3hi closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

2 participants