Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruff and mypy #57

Merged
merged 3 commits into from
Jan 22, 2024
Merged

add ruff and mypy #57

merged 3 commits into from
Jan 22, 2024

Conversation

MP91
Copy link
Contributor

@MP91 MP91 commented Jan 22, 2024

  • fix linter errors

- fix linter errors
Copy link

github-actions bot commented Jan 22, 2024

File Coverage Lines Branches
All files 20% 26% 14%
desired_state_generator/src/gen_desired_state.py 36% 41% 32%
runtime_k3d/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_k3d/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_k3d/src/runtime/controlplane.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-down.py 0% 0% 0%
runtime_k3d/src/runtime/runtime-up.py 0% 0% 0%
runtime_k3d/src/runtime/runtime.py 0% 0% 0%
runtime_k3d/src/runtime/deployment/gen_helm.py 29% 39% 19%
runtime_k3d/src/runtime/deployment/gen_podspec.py 44% 54% 35%
runtime_k3d/src/runtime/deployment/lib.py 93% 87% 100%
runtime_kanto/src/app_deployment/build_vehicleapp.py 0% 0% 0%
runtime_kanto/src/app_deployment/deploy_vehicleapp.py 0% 0% 0%
runtime_kanto/src/runtime/controlplane_kanto.py 0% 0% 0%
runtime_kanto/src/runtime/runtime.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_down.py 0% 0% 0%
runtime_kanto/src/runtime/runtime_up.py 0% 0% 0%
runtime_local/src/local_lib.py 22% 22% 0%
runtime_local/src/run-dapr-sidecar.py 0% 0% 0%
runtime_local/src/run-vehicle-app.py 0% 0% 0%
runtime_local/src/run_service.py 30% 42% 18%
runtime_local/src/runtime-up.py 0% 0% 0%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against a5f24ec

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MP91 MP91 merged commit 8a3ae1a into main Jan 22, 2024
8 checks passed
@MP91 MP91 deleted the fix/linter branch January 22, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants