Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] License information of generated notice partially empty/not filled #19

Closed
BjoernAtBosch opened this issue Feb 9, 2023 · 2 comments
Closed

[BUG] License information of generated notice partially empty/not filled #19

BjoernAtBosch opened this issue Feb 9, 2023 · 2 comments

Comments

@BjoernAtBosch
Copy link
Member

BjoernAtBosch commented Feb 9, 2023 •
edited
Loading

Issue:
The license info in the generated dependencies table (of workflows) is partially empty.
The issue occurs sporadically, only.

Reason:
GitHub's rate limit mechanism prevents accessing that information in the respective repositories.

Example run with occurencies:
https://github.com/eclipse-velocitas/vehicle-app-cpp-template/actions/runs/4125038541/jobs/7125067343
See "section" "Getting dependencies for Workflows"

Workaround:
Try re-running license check 😔

Suggested fix:
Tbd
BjoernAtBosch added a commit that referenced this issue Feb 21, 2023
@BjoernAtBosch
[BugFix] Use GitHub token when getting license info for workflows (is…
12525c6 
…sue #19) (#21)

Fix for issue#19: Fix (or at least reduce) GitHub rate limit issues when getting the license information for GitHub workflows via GitHub API by passing a GitHub token.
@BjoernAtBosch
Copy link
Member Author

BjoernAtBosch commented Feb 21, 2023 •
edited
Loading

Fix provided: #21, tag: v1.2.2, commit #12525c6107f5eecc97abff5370ba51b6e1951c71

The fix passes the GiHub token to the API requests severely reducing the probability of request rejection due to rate limiting.

This was referenced Feb 22, 2023
Merged
Merged
@BjoernAtBosch
Copy link
Member Author

Fix seems to work - therefore closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BjoernAtBosch