Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add authentication for mqtt client #77

Merged
merged 5 commits into from
Mar 1, 2024
Merged

add authentication for mqtt client #77

merged 5 commits into from
Mar 1, 2024

Conversation

MP91
Copy link
Contributor

@MP91 MP91 commented Feb 21, 2024

  • use baseimage and cli in sdk

Describe your changes

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

BjoernAtBosch
BjoernAtBosch requested changes Feb 27, 2024
View reviewed changes
sdk/src/sdk/pubsub/MqttPubSubClient.cpp Outdated Show resolved Hide resolved
sdk/src/sdk/pubsub/MqttPubSubClient.cpp Outdated Show resolved Hide resolved
sdk/include/sdk/IPubSubClient.h Outdated Show resolved Hide resolved
.velocitas.json Show resolved Hide resolved
BjoernAtBosch
BjoernAtBosch previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BjoernAtBosch
BjoernAtBosch approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MP91 MP91 merged commit 8e487de into main Mar 1, 2024
5 checks passed
@MP91 MP91 deleted the feat/add-mqtt-auth branch March 1, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

@kse3hi kse3hi Awaiting requested review from kse3hi

@doosuu doosuu Awaiting requested review from doosuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MP91 @BjoernAtBosch