Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pre-commit #89

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Enable pre-commit #89

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0df4ca
Enable pre-commit
kse3hi Jan 11, 2023
8cf2bcd
Test
kse3hi Jan 11, 2023
3b1bc5f
Fix review findings
kse3hi Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
pip install -r app/tests/requirements-tests.txt

- name: Run Linters
if: ${{ false }}
kse3hi marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ true }}
uses: ./.github/actions/pre-commit-action

- name: Clone Release Documentation Action repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ jobs:
tag=$(echo docker://$REGISTRY/$VAPP_NAME:$VAPP_VERSION | tr '[:upper:]' '[:lower:]')
echo "Copy vApp image $VAPP_IMAGE to '$tag'"
skopeo copy --all oci-archive:$VAPP_IMAGE "$tag"

- name: ${{ matrix.component.Name }} -- Download CI artifacts
uses: dawidd6/action-download-artifact@v2
with:
workflow: ci.yml
workflow_conclusion: success

- name: ${{ matrix.component.Name }} -- Upload AppManifest.json to artifacts"
uses: actions/upload-artifact@v3
with:
Expand Down